Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ploomber-extension from required dependencies #1025

Closed
hlapp opened this issue Sep 9, 2024 · 5 comments
Closed

Remove ploomber-extension from required dependencies #1025

hlapp opened this issue Sep 9, 2024 · 5 comments

Comments

@hlapp
Copy link

hlapp commented Sep 9, 2024

The "Share notebook" button created (in my understanding) by the ploomber-extension dependency is not acceptable in my environment (educational institution). (It uses a non-vetted platform and is thus by definition insecure.)

It seems this dependency was added months ago, for the sole reason to have this button. It appears none of the jupysql functionality is otherwise dependent on or affected by this extension, as arguably it should be if it wants to be a successor to ipython-sql.

Hence, how can this be disabled by default, and/or be excluded from the mandatory requirements.

@edublancas
Copy link

Hi,

we're deprecating the "share notebook" feature so we'll remove the ploomber-extension soon.

for now, you can write an installation script that uninstalls it:

pip install jupysql
pip uninstall ploomber-extension

if that doesn't work, we'd appreciate your help with a PR: https://github.com/ploomber/jupysql-plugin/

so we remove ploomber-extension

hlapp added a commit to Duke-GCB/jupysql that referenced this issue Sep 9, 2024
@hlapp
Copy link
Author

hlapp commented Sep 9, 2024

I added a PR. ploomber-extension is actually not used in jupysql-plugin/, AFAICT.

@edublancas
Copy link

edublancas commented Sep 9, 2024

Hi @hlapp, you mentioned you're being forced to move to ipython-sql because of our telemetry and a a few other things.

for full transparency: we're a small startup putting our own resources to fund JupySQL's development. it seems like our business model does not fit your requirements, so I'll have to politely decline working with you, as we cannot accommodate your requests

@edublancas edublancas closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2024
@hlapp
Copy link
Author

hlapp commented Sep 9, 2024

Is there a reason you refused this (#1026) PR? You at first expressly asked for it, and I obliged your request and submitted it.

@hlapp
Copy link
Author

hlapp commented Sep 18, 2024

I think this was addressed through #1028. Thanks @edublancas and @neelasha23 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants