Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document how to generate vendor-agnostic SQL with sqlglot #277

Closed
edublancas opened this issue Mar 21, 2023 · 3 comments · Fixed by #371
Closed

document how to generate vendor-agnostic SQL with sqlglot #277

edublancas opened this issue Mar 21, 2023 · 3 comments · Fixed by #371
Assignees

Comments

@edublancas
Copy link

we just merged a big PR from @tonykploomber (#164) that will allow us to improve JupySQL compatibility across multiple SQL dialects. However, since we expect to keep adding features that run SQL queries on the user's behalf, we need to document how to do it.

Tony: please document your learning on using SQLglot for producing vendor-agnostic SQL queries so other contributors know how to do it.

@edublancas
Copy link
Author

add it to the developer guide: https://jupysql.ploomber.io/en/latest/community/developer-guide.html

@tonykploomber
Copy link

tonykploomber commented Mar 23, 2023

Now we have a plan to drop sqlglot, this might not valid anymore
#307

@edublancas
Copy link
Author

but we'll still keep (at least for now) for transpiling some internal queries. this is still useful but not urgent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants