-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: sqlglot to formalize sql clause #164
Add: sqlglot to formalize sql clause #164
Conversation
…ql-query-generation
➤ Ido Michael commented: Eduardo Blancas looks like it's also creating ones for PRs? |
@edublancas I think it somehow closed the PR? |
yeah, it's because I deleted the task on Asana, I'll close the remaining tasks an re-open the PRs |
After sqlglot updated to 3.7, the build issue was resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, we're getting closer!
a few things. I opened #245 so we make a release and give some time to users to update their code.
since this is a breaking API change, we need to update the __version__
in the __init__.py
file (0.7dev) and also create a new section in the changelog with such version and put the new changelog entry there
finally, we need to pin the version in setup.py, I'm guessing we need sqlglot>=11.3.7
I'll make a release now that will include #249 - we can now delete the warnings we added there in this PR and turn them into errors so please rebase. also address the comments from my previous comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a comment and fixed some merge conflicts
…ykploomber/jupysql into 158-more-robust-sql-query-generation
…ql-query-generation
awesome! 🎉🎉 |
Finally! |
Describe your changes
--with
parameter with double syntax issue on mysql (--savename
and --withname
is creating an error with the CTE name appearing with double quotes in MySQL #145)sqlplot histogram
with double quote syntax issue on mysqlIssue ticket number and link
Close #158 - Integrate with sqlglot
Close #145 -
--with
parameter with double syntax issue on mysqlChecklist before requesting a review
📚 Documentation preview 📚: https://jupysql--164.org.readthedocs.build/en/164/