Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uploading failed reference images as artifacts #543

Closed
edublancas opened this issue May 30, 2023 · 0 comments · Fixed by #607
Closed

uploading failed reference images as artifacts #543

edublancas opened this issue May 30, 2023 · 0 comments · Fixed by #607
Assignees
@neelasha23
Labels
good first issue Good for newcomers stash Label used to categorize issues that will be worked on next

Comments

@edublancas
Copy link

some of our tests produce images and they're compared against a baseline one. when the tests fail, it's difficult to debug failing tests because we don't have access to the images.

we can modify our CI workflow so it uploads the images if the tests fail: https://github.com/actions/upload-artifact
@edublancas edublancas added good first issue Good for newcomers stash Label used to categorize issues that will be worked on next labels May 30, 2023
@edublancas edublancas mentioned this issue May 30, 2023
Merged
4 tasks
@edublancas edublancas mentioned this issue Jun 6, 2023
Closed
@neelasha23 neelasha23 mentioned this issue Jun 9, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neelasha23 neelasha23

Labels
good first issue Good for newcomers stash Label used to categorize issues that will be worked on next
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upload test artifacts neelasha23/jupysql
2 participants
@edublancas @neelasha23