-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload test artifacts #607
Conversation
Do we want these 2 images per test : test image generated + |
what's the difference? if we go with option 1 (test image generated + *-failed-diff.png), what images/data are we not uploading? |
This folder contains all baseline images, all test generated images (for failed cases as well as success cases) + For now the entire folder is being uploaded as artifact. I have modified the baseline images for testing purpose. Will remove it once the workflow is approved. |
ok, this looks good. please fix the baseline images so we can merge |
Fixed the baseline images. There's some issue with the MariaDB integration tests. Verified on a clean PR as well, so the integration CI is failing. |
can you merge from master? the mariadb issue has been fixed |
trigger workflows ../../.github/workflows/ci.yaml Workflow edited moved workflow fail changed path moved to test moved to test moved to test moved to test moved to test added versions baseline images wildcard integration Uploading entire folder live revert baseline Empty commit
Done. |
Describe your changes
Uploading failed test images
Issue number
Closes #543
Checklist before requesting a review
pkgmt format
📚 Documentation preview 📚: https://jupysql--607.org.readthedocs.build/en/607/