Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload test artifacts #607

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Upload test artifacts #607

merged 1 commit into from
Jun 19, 2023

Conversation

neelasha23
Copy link

@neelasha23 neelasha23 commented Jun 9, 2023

Describe your changes

Uploading failed test images

Issue number

Closes #543

Checklist before requesting a review


📚 Documentation preview 📚: https://jupysql--607.org.readthedocs.build/en/607/

@neelasha23 neelasha23 added the allow-workflow-edits Allow edits to .github/workflows label Jun 9, 2023
@neelasha23 neelasha23 marked this pull request as draft June 9, 2023 10:53
@neelasha23
Copy link
Author

Do we want these 2 images per test : test image generated + *-failed-diff.png, or the entire content of result_images?
@edublancas

@edublancas
Copy link

Do we want these 2 images per test : test image generated + *-failed-diff.png, or the entire content of result_images?

what's the difference? if we go with option 1 (test image generated + *-failed-diff.png), what images/data are we not uploading?

@neelasha23
Copy link
Author

neelasha23 commented Jun 11, 2023

what's the difference? if we go with option 1 (test image generated + *-failed-diff.png), what images/data are we not uploading?

This folder contains all baseline images, all test generated images (for failed cases as well as success cases) + *-failed-diff.png.

For now the entire folder is being uploaded as artifact. I have modified the baseline images for testing purpose. Will remove it once the workflow is approved.

@edublancas

@neelasha23 neelasha23 marked this pull request as ready for review June 12, 2023 05:31
@edublancas
Copy link

ok, this looks good. please fix the baseline images so we can merge

@neelasha23
Copy link
Author

Fixed the baseline images. There's some issue with the MariaDB integration tests. Verified on a clean PR as well, so the integration CI is failing.
@edublancas

@edublancas
Copy link

can you merge from master? the mariadb issue has been fixed

trigger workflows

../../.github/workflows/ci.yaml

Workflow edited

moved workflow

fail

changed path

moved to test

moved to test

moved to test

moved to test

moved to test

added versions

baseline images

wildcard

integration

Uploading entire folder

live

revert baseline

Empty commit
@neelasha23
Copy link
Author

can you merge from master? the mariadb issue has been fixed

Done.

@edublancas

@edublancas edublancas merged commit c09541f into ploomber:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-workflow-edits Allow edits to .github/workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uploading failed reference images as artifacts
2 participants