Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks triggered when only modifying changelog and doc/ #661

Closed
edublancas opened this issue Jun 24, 2023 · 4 comments · Fixed by #668
Closed

tasks triggered when only modifying changelog and doc/ #661

edublancas opened this issue Jun 24, 2023 · 4 comments · Fixed by #668
Assignees

Comments

@edublancas
Copy link

edublancas commented Jun 24, 2023

I realized that unit tests are triggered even though I only modified doc/ and CHANGELOG.md: #660

my understanding is that if my PR only modifies the CHANGELOG.md or files within doc/ tests should not run

image

seem like this line (

if: needs.preliminary.outputs.check_doc_modified == 'failure'
) which appears in a few places is not correctly getting the exit code from the step that determines if only doc/ or changelog.md have been modified

@anupam-tiwari
Copy link

does this work?:

    if: needs.preliminary.outputs.check_doc_modified == 'failure' && !contains(github.event.head_commit.modified, 'CHANGELOG.md') && !contains(github.event.head_commit.modified, 'docs/')

@mehtamohit013
Copy link

@edublancas
Ths test shouldn't give a failure as excluding doc and CHANGELOG.md nothing has been modified. I will look into it and check it out on dummy repo.

@mehtamohit013
Copy link

mehtamohit013 commented Jun 24, 2023

@edublancas
Can i get access to create a branch in the repo? It will be easier for me to debug, because pkgmt tests are working.

@edublancas
Copy link
Author

jupysql repo? you have write access. I think that will allow you to push new branches. but let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants