-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed CI (Doc checking) #668
Conversation
@edublancas Also created a PR in pkgmt with changes: ploomber/pkgmt#61 |
@mehtamohit013 do we need to merge the pkgmt PR in order to test it? Also, I'm not sure I understand this PR (667) . If we changed only docs and/or changelog - No other test should run, right? according to this summary, it looks like the CI tests will run even when we changed only docs/changelog. If it's possible, I think we should test it as follows
I think we can test all these cases in this PR by modifying the relevant files each time. |
Also, I have corrected a docstring here, changed no code or logic |
No
As you see, in the summary, the jobs are skipped. Also, you can see |
Describe your changes
Correct Syntax:
-e doc CHANGELOG.md
Issue number
Closes #661
Checklist before requesting a review
pkgmt format
📚 Documentation preview 📚: https://jupysql--668.org.readthedocs.build/en/668/