Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require toml package for Python versions before 3.11 #1005

Closed
wants to merge 1 commit into from
Closed

Require toml package for Python versions before 3.11 #1005

wants to merge 1 commit into from

Conversation

xofbd
Copy link

@xofbd xofbd commented Mar 27, 2024

Describe your changes

This is an alternative to PR #1004

Issue number

Closes #X

Checklist before requesting a review


📚 Documentation preview 📚: https://jupysql--1005.org.readthedocs.build/en/1005/

Starting with Python 3.11, the standard library has TOML parsing with
tomllib.
@xofbd xofbd requested a review from edublancas as a code owner March 27, 2024 13:57
@edublancas
Copy link

most users don't use toml to configure their projects, that's why we made it an optional dependency

@edublancas edublancas closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants