-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
230 customizing results output #274
230 customizing results output #274
Conversation
is this ready for review? looks like you ran some markdown formatted cause the CHANGELOG was edited |
Yeah, it is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check your formatting settings, I see a lot of changes in files that should not be edited (example, the CHANGELOG and some test files)
Will do that. |
I have added a new table with urls in the conftest file to run a few tests. Is it alright? |
If you can't use/utilize the existing fixtures then it's fine. |
Hi @edublancas can you approve the workflow checks. Thank You. |
@AnirudhVIyer please make sure you've added the issue number it closes in the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Eduardo, to make the URLs clickable in a dataframe, we need to add a style function that returns a Styler object, not the original dataframe. If we return the Styler object, users won't be able to conduct further analysis on it. Therefore, I added a styling function to the returned dataframe as an attribute. Users can use this attribute to display clickable links when they want to but still retain the original dataframe for further use. you can display the dataframe with styling like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, since getting this to work with pandas involves users knowing a bit of the implementation details, I think it's better to only keep the URL parsing the ResultSet - it's ok if the links go away when turning it into a pandas data frame
Sure, I will make the required changes. |
I have removed the pandas url attribute. |
great work! |
thank you! |
Thanks for committing @AnirudhVIyer ! |
Enabled urls in ResultSet output and pandas DataFrame to be clickable
Issue ticket number and link
Closes #230
Checklist before requesting a review
📚 Documentation preview 📚: https://jupysql--274.org.readthedocs.build/en/274/