display improvements #432
display improvements #432
Conversation
|
I think this has to be on the side somewhere eventually, it's fine if we define the logic here and build the widget or CSS view later on. |
|
@yafimvo, @idomic: addressed all the comments. please give it another pass. one important thing: while debugging my tests I realized we had some shared state (a new test would start with existing connections from previous tests), so I added a This led to another problem: I found out a buggy test that started failing because it was inadvertently using a connection from another test. Since the test was checking legacy behavior, I removed the test |
| assert "***" in conn.url | ||
| assert conn.name == "user@db" | ||
| assert isinstance(conn.engine, Engine) | ||
| assert conn.dialect |
There was a problem hiding this comment.
Do we really need those 2?
conn.dialect, conn.session
| assert "<duckdb.DuckDBPyConnection" in txt | ||
| assert "sqlite:///my.db" in txt | ||
| assert "duckdb:///somedb" in txt | ||
| assert "sqlite://" in txt |
There was a problem hiding this comment.
Same thing if sqlite:///my.db is in txt, sqlite: will definitely be there. so maybe parameterization is better here.
This PR improves the messages displayed to the user
Describe your changes
--aliaswhen opening a connection (display improvements #432)api/magic-sql.mdsince it incorrectly stated that listing functions was--list, but it's--connections(display improvements #432)ConnectionattributesIssue number
Closes #X
Checklist before requesting a review
pkgmt format📚 Documentation preview 📚: https://jupysql--432.org.readthedocs.build/en/432/