-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improving duckdb + autopandas performance #469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edublancas Nice improvement! ~6.5 sec vs ~260 ms
Should we see the benchmark in the docs?
It's intentionally not part of the docs, as this is how it should operate regardless (let's say without JupySQL). |
Describe your changes
.df()
)ResultSet
constructor to the topResultSet
, no longer a subclass of list (using composition instead of inheritance)ResultSet
testsIssue number
Closes #451
Checklist before requesting a review
pkgmt format
📚 Documentation preview 📚: https://jupysql--469.org.readthedocs.build/en/469/