Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes CD workflow #472

Merged
merged 3 commits into from
May 3, 2023
Merged

fixes CD workflow #472

merged 3 commits into from
May 3, 2023

Conversation

edublancas
Copy link

@edublancas edublancas commented Apr 28, 2023 •
edited by github-actions bot
Loading

Describe your changes

fixed CD workflow. the event wasn't triggered because we didn't add tags to the config.

Issue number

Closes #X

Checklist before requesting a review

📚 Documentation preview 📚: https://jupysql--472.org.readthedocs.build/en/472/

@edublancas edublancas added the allow-workflow-edits Allow edits to .github/workflows label Apr 28, 2023
@edublancas edublancas marked this pull request as ready for review April 28, 2023 21:37
@edublancas edublancas requested a review from idomic April 28, 2023 21:37
idomic
idomic reviewed May 1, 2023
View reviewed changes
Copy link

@idomic idomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@idomic idomic merged commit 947af61 into master May 3, 2023
@idomic idomic deleted the edublancas-patch-2 branch May 3, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idomic idomic idomic left review comments

Assignees
No one assigned
Labels
allow-workflow-edits Allow edits to .github/workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edublancas @idomic