Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
%sqlplot bar and pie charts #508
%sqlplot bar and pie charts #508
Changes from 15 commits
93e0672
63598ac
1abbab8
1d56891
10dc8a5
8ed37ac
e7eae4d
3739263
f8d962c
4e6b609
3a7edd7
f381423
fed5bbd
64ce72d
3896866
8697181
db3e167
ad81d68
e49ecb5
f6befa2
b57626f
5bd5045
36ab740
2748470
e52e909
dbf1425
955463d
61817df
4163e5d
46aacb0
c60d48e
c125c91
d43cc9e
d2ed0f3
1633599
3192c9a
4ab7954
43f99ed
8cfce28
548890f
e259e33
5f43ecb
ec33a6d
54afbef
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add support for NULL values? you can run a query to filter them first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I raise some warning when there is NULL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. not a warnings.warn, but printing a message saying that we're removing NULLs makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the message be printed only when there is NULL or a generic message?
Currently added a general message:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i didn't think about this. we have two options
let's implement 2. this implies that we won't show any message to the user since we'll filter out NULLs all the time - so there's no point in showing a message. we can later optimize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edublancas
Implemented
2
option + Generic null Message for info :Sample SQL query: