--alias fix

[AnirudhVIyer]

Describe your changes

Modified the set method in the Connection Class such that: if a connection with a descriptor exists, we check it's alias with the new alias argument.

Issue number

Closes #532

Checklist before requesting a review

• Performed a self-review of my code
• Formatted my code with pkgmt format
• Added tests (when necessary).
• Added docstring documentation and update the changelog (when needed)

---

📚 Documentation preview 📚: https://jupysql--600.org.readthedocs.build/en/600/

[AnirudhVIyer]

@edublancas made the changes and fixed the bug.

However, when i format and lint, it formats and changes the magic-plot.md, magic-sql.md and ggplot-interactive.md.
I made no changes to those files. Tried with a different branch but still got the same result. Has there been any linting changes made on the master branch?

[edublancas]

don't worry about the formatting changes (unsure about why it's happening but we can merge it)

just add some unit tests

[anupam-tiwari]

@AnirudhVIyer I think you removed your code

[AnirudhVIyer]

@AnirudhVIyer I think you removed your code

Yeah, an integration test is failing, trying to figure that out

[mehtamohit013]

@AnirudhVIyer
It seems like other PR also have test failing. Make sure you merge with the master and test again

[AnirudhVIyer]

@AnirudhVIyer It seems like other PR also have test failing. Make sure you merge with the master and test again

@mehtamohit013 I merged with master. The test is still failing, code works on binder though. It was passing all tests until Friday evening.

[edublancas]

@tonykploomber: can you check the integration tests? looks like they're failing but this PR didn't change them. so perhaps some update in the docker image we're using?

[jinniw43805]

@edublancas
This is something we found earlier, #614

[edublancas]

great work!

[jinniw43805]

@edublancas
Any idea why tests are skipped when merged to master?

[mehtamohit013]

@edublancas
Any idea why tests are skipped when merged to master?

It may be due to my recently merged PR. In check_doc job, I am taking the git diff of the current branch with the master branch. This works great when running actions for a PR, but when merging, there is no diff between the master latest commit and the current branch i.e. master latest commit. May have to modify the test to run only for PR, and run all the tests when merging

What is your opinion on the above issue? @edublancas @jinniw43805 @tonykploomber

Update: Added a PR. Currently testing