518 refactor magic cmd #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edublancas ready for review |
edublancas
requested changes
Jun 23, 2023
|
Sure, looking into the changes |
…yer/jupysql into 518-refactor-magic_cmd merge upstram
yafimvo
reviewed
Jun 25, 2023
edublancas
requested changes
Jun 26, 2023
edublancas
approved these changes
Jun 27, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I have refactored the
magic_cmd.py file by moving each individual command logic to a separate location. Now there is asrc/cmdfolder with the required function to execute each command.magic_cmd.pyhas functions that would validate and route the commands.Issue number
Closes #518
Checklist before requesting a review
pkgmt format📚 Documentation preview 📚: https://jupysql--654.org.readthedocs.build/en/654/