Resultset distinguishable #655
Conversation
Sure. Should I keep the |
|
please reduce all of them from ResultSet until PolarsDataFrame() |
There was a problem hiding this comment.
lgtm. added some minor notes.
General thought:
I agree with @edublancas, I'm not sure the bottom message is clear enough. Maybe we can style it as the Truncated message (smaller font and italic style)?
|
Changes are
If we want smaller text for 1), I will make the change. |
Adding description after html representation of ResultSet and error message when invalid operation is performed update changelog update changelog for #468 making resultset distinguishable update run with lint modifying based on comments smaller font and link to data frame modify_resultset_test
There was a problem hiding this comment.
I think it looks good.
Why do we get this message here? is this the expected behavior?
@edublancas
I just noticed this message appears in our docs as well. What do you think about it?
|
@yafimvo: good points. I'll open issues to follow up in your observations |
Making ResultSet distinguishable (ploomber#655)
Describe your changes
Adding description after html representation of
ResultSetand error message for AttributeError when invalid operation is performedIssue number
Closes #468
Checklist before requesting a review
pkgmt format📚 Documentation preview 📚: https://jupysql--655.org.readthedocs.build/en/655/