Move feat from %sqlrender to %sqlcmd snippets #681
Conversation
bbeat2782
requested review from
edublancas,
neelasha23 and
yafimvo
as code owners
|
Closed the original PR and created a new PR due to the change in cmd functions location. The original PR is here. Unresolved questions from the previous PR's comments
|
yes, let's remove it |
@edublancas I made the change (deleting double space in the |
| print(chinstrap_sub_snippet) | ||
| ``` | ||
|
|
||
| This returns the stored snippet `chinstrap_sub`. |
There was a problem hiding this comment.
After this add some sentence like, Now, let's look at you to delete stored snippets.
Please verify any doc changes using Grammarly for typos/ syntax issues
There was a problem hiding this comment.
Please click the Resolve Conversation button whenever you resolve a review comment
doc/api/magic-snippets.md
Outdated
| %sqlcmd snippets -d gentoo | ||
| ``` | ||
|
|
||
| This deletes the stored snippet `gentoo`. | ||
|
|
||
| To demonstrate `force-delete` let's create a snippet dependent on `chinstrap` snippet. | ||
| To demonstrate `force-delete` let's first confirm there is a snippet dependent on `chinstrap` snippet. |
There was a problem hiding this comment.
This doesn't confirm whether chinstrap_sub is dependent on chinstrap. It just displays the available snippets.
Maybe just mention, we have created the chinstrap_sub which is dependent on chinstrap. To delete chinstrap we need to use force-delete (please rephrase as needed)
| In the given example, we demonstrated JupySQL's usage as a tool for managing large SQL queries in Jupyter Notebooks. It effectively broke down a complex query into smaller, organized parts, simplifying the process of analyzing a record store's sales database. By using JupySQL, users can easily maintain and reuse their queries, enhancing the overall data analysis experience. |
There was a problem hiding this comment.
There is no change in the wording. The change is coming from deleting a double new line, and I just checked this occurs automatically when I open a markdown file in jupyter lab by opening it in notebook format.
I will add the new line back to remove this change.
Moved features, added FutureWarning, update API Reference documentation, modified test functions update changelog update changelog for #647 Update CHANGELOG.md documentation change of moving sqlrender feature manually relocating changes resolving docs build failed lint fixing readthedocs remove invalid snippet from documenation subquery and more detailed error message added lint change in formatting update toc ci using pretty_print ci delete double space from magic-snippet Update CHANGELOG.md change in documention ci
Move feat from %sqlrender to %sqlcmd snippets (ploomber#681)
Describe your changes
Moved
%sqlrenderfeature to@sqlcmd snippets, added FutureWarning to%sqlrender, updated documentations, and modified test functions to use@sqlcmd snippetsIssue number
Closes #647
Checklist before requesting a review
pkgmt format📚 Documentation preview 📚: https://jupysql--681.org.readthedocs.build/en/681/