Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "too many open files" when running tests #696

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

edublancas
Copy link

@edublancas edublancas commented Jun 30, 2023

Describe your changes

Fixed an issue that caused errors when running unit tests.

Issue number

Closes #X

Checklist before requesting a review


📚 Documentation preview 📚: https://jupysql--696.org.readthedocs.build/en/696/

@edublancas edublancas added the no-changelog This PR doesn't require a changelog entry label Jun 30, 2023
@tonykploomber
Copy link

Thanks for the fix, I do see this issue recently in integration testing too

@edublancas edublancas marked this pull request as ready for review June 30, 2023 02:49
@edublancas edublancas requested a review from yafimvo as a code owner June 30, 2023 02:49
@edublancas
Copy link
Author

@tonykploomber I think this will fix the issue for integration tests but please open an issue if it doesn't

Copy link

@yafimvo yafimvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@edublancas edublancas merged commit 2456382 into master Jul 3, 2023
@edublancas edublancas deleted the fix-too-many-open-files branch July 3, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog This PR doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants