Adding --with for CTE
#705
Conversation
|
@edublancas Please review |
There was a problem hiding this comment.
Added some comments.
@edublancas @neelasha23
General thought about the error message:
this part: If using CTEs, you may pass the --with argument explicitly.
- What do you think if we add a link to our
--withdocumentation - Explain in our
--withdocs why and when we should use--with(maybe to show this exact case with the error and the solution?)
neelasha23
force-pushed
the
cte
branch
2 times, most recently
from
b29735a
to
f5540f2
Compare
Added these @yafimvo @edublancas |
|
A few doubts from the notebook: 
`This is now complaining about first_cte.` : I'm not sure which error? I don't see anything in this cell. Also, this would complain about `first_cte` since sqlglot wouldn't be able to parse the query?
This should work if we pass `--with` while saving the `second_cte` like:
|
I'm referring to the cell below the "this is now complaining"
Ah, you're right. there's no way around it and users will have to pass then the only missing thing is improving the error message. |
There was a problem hiding this comment.
Looks good! I guess what's left is the error message like @edublancas mentioned.
doc/user-guide/py-scripts.md
Outdated
| @@ -83,7 +83,7 @@ The percent format is also supported by `PyCharm Professional`: | |||
|
|
|||
|  | |||
|
|
|||
| [Click here](https://jupytext.readthedocs.io/en/latest/formats.html#the-percent-format) for more details on the percent format. | |||
| [Click here](https://jupytext.readthedocs.io/en/latest/formats-scripts.html#the-percent-format) for more details on the percent format. | |||
There was a problem hiding this comment.
I opened a new PR for this so we can fix our CI quickly. After we merge it, you can rebase.
I'm not clear on this part. Are u suggesting to remove the below specific error message completely? This was added as part of this issue |
Lint exception Removed deprecation tests Removed generic exception condition removed duckdb exception duckdb exception reraise exception integration tests fix Integration tests Integration tests error message assert usageerror error msg Error added oracle integration tests docs replaced numbers table tests tests string formats fix tests display module for print changed to print test fix docs doc link plot docs plot docs refactor plots import moved lint error message added cte msg removed syntax error
|
Have modified the error message. However, I still see the old message in docs. In local build I see the new one: 
Do you also see the old one? @edublancas |
Describe your changes
Adding
--withagainIssue number
Closes #684
Checklist before requesting a review
pkgmt format📚 Documentation preview 📚: https://jupysql--705.org.readthedocs.build/en/705/