-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix result when summarize is passed to duckdb #841
Conversation
For context, With sqlalchemy==1.4.49, result of query is stored in So as @edublancas suggested here, returning the |
@@ -727,7 +727,7 @@ def _connection_execute(self, query, parameters=None): | |||
# TODO: we can parse the query to ensure that it's a SELECT statement | |||
# for example, it might start with WITH but the final statement might | |||
# not be a SELECT | |||
is_select = first_word_statement in {"select", "with", "from"} | |||
is_select = first_word_statement in {"select", "with", "from", "summarize"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a note explaining why we're adding "summarize" here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Describe your changes
Now the correct result is displayed when
SUMMARIZE
is passed to duckdb with sqlalchemy connectiontesting_summarize.ipynb.zip
Issue number
Closes #836
Checklist before requesting a review
pkgmt format
📚 Documentation preview 📚: https://jupysql--841.org.readthedocs.build/en/841/