Skip to content

Commit

Permalink
Merge pull request #293 from BSd3v/bump-to-v31_2
Browse files Browse the repository at this point in the history
Bump to AG Grid v31.2
  • Loading branch information
BSd3v authored Apr 25, 2024
2 parents 295cc40 + e6cafea commit 5bcabd1
Show file tree
Hide file tree
Showing 5 changed files with 60 additions and 31 deletions.
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,24 @@ Links "DE#nnn" prior to version 2.0 point to the Dash Enterprise closed-source D

### Changed
- [#273](https://github.com/plotly/dash-ag-grid/pull/273) increased the timeout for `getApiAsync` to 2 minutes.
- [#281](https://github.com/plotly/dash-ag-grid/pull/281) webpack is now designed to build quicker, excludes `node_modules` and uses a different parser
- [#287](https://github.com/plotly/dash-ag-grid/pull/287) bumping to v`31.2.1` for the grid

### Added
- [#270](https://github.com/plotly/dash-ag-grid/pull/270)
- support for `eventListeners` to be added to the grid that get loaded upon `gridReady`
- `eventListeners` are added upon `gridReady` only, if you need to add or remove other event listeners, please use the `getApi` or `getApiAsync` methods
- added default for `selectedRows` to be `[]`

### Fixed
- [#283](https://github.com/plotly/dash-ag-grid/pull/283)
- `selectedRows` can now be passed along with the `rowData`
- fixes [#274](https://github.com/plotly/dash-ag-grid/issues/274)
- fixes [#282](https://github.com/plotly/dash-ag-grid/issues/282)
- [#287](https://github.com/plotly/dash-ag-grid/pull/287)
- `aggFuncs` can now be passes as an object from the grid to be mapped to functions
- fixes [#278](https://github.com/plotly/dash-ag-grid/issues/278)


## [31.0.1] - 2024-02-07

Expand Down
66 changes: 39 additions & 27 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@
"dependencies": {
"@emotion/react": "^11.11.3",
"@emotion/styled": "^11.11.0",
"ag-grid-community": "31.1.1",
"ag-grid-enterprise": "31.1.1",
"ag-grid-react": "31.1.1",
"ag-grid-community": "31.2.1",
"ag-grid-enterprise": "31.2.1",
"ag-grid-react": "31.2.1",
"@mui/icons-material": "^5.15.7",
"@mui/material": "^5.15.7",
"d3-format": "^3.1.0",
Expand Down
2 changes: 1 addition & 1 deletion src/lib/fragments/AgGrid.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,7 @@ export default class DashAgGrid extends Component {
const {rowModelType, eventListeners} = this.props;

if (rowModelType === 'infinite') {
params.api.setDatasource(this.getDatasource());
params.api.setGridOption('datasource', this.getDatasource());
}

if (eventListeners) {
Expand Down
6 changes: 6 additions & 0 deletions tests/test_selected_rows.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ def test_sr2_selected_rows_rowdata(dash_duo):
dag.AgGrid(
id='grid',
columnSize="sizeToFit",
columnDefs=[{'field': 'A'}],
dashGridOptions={
"rowHeight": None,
"domLayout": "normal",
Expand Down Expand Up @@ -152,6 +153,8 @@ def update_selected_row_info(selected_rows):

grid = utils.Grid(dash_duo, "grid")

grid.wait_for_header_text(0, 'A')

dash_duo.find_element('#update-button').click()

grid.wait_for_cell_text(0, 0, "1")
Expand Down Expand Up @@ -186,6 +189,7 @@ def test_sr3_selected_rows_modes(dash_duo):
dag.AgGrid(
id='grid',
columnSize="sizeToFit",
columnDefs=[{'field': 'A'}],
dashGridOptions={
"rowHeight": None,
"domLayout": "normal",
Expand Down Expand Up @@ -245,6 +249,8 @@ def update_selected_row_info(selected_rows):

grid = utils.Grid(dash_duo, "grid")

grid.wait_for_header_text(0, 'A')

dash_duo.find_element('#update-button').click()

grid.wait_for_cell_text(0, 0, "1")
Expand Down

0 comments on commit 5bcabd1

Please sign in to comment.