Skip to content

Commit

Permalink
Merge pull request #341 from plotly/run-tests-on-dist
Browse files Browse the repository at this point in the history
Fix typo in venv activation
  • Loading branch information
ndrezn authored Nov 22, 2024
2 parents f81e04e + 74c1f36 commit 71ae0ec
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,10 @@ jobs:
uv pip install ".[dev]"
npm i
shell: bash
- name: Run tests
# Run all tests before generating the distribution
- name: Build package
run: |
source .venv/bin/activate
npm run build
npm run test
shell: bash
- name: Generate distribution
# Run setup.py to generate the distribution
Expand All @@ -45,7 +43,7 @@ jobs:
# Run tests again using the generated wheel file
run: |
uv venv test-dist
source dist/bin/activate
source test-dist/bin/activate
WHL_FILE=$(ls dist/*.whl)
uv pip install "${WHL_FILE}[dev]"
npm run test
Expand Down

0 comments on commit 71ae0ec

Please sign in to comment.