Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues from #281 #285

Closed
BSd3v opened this issue Apr 22, 2024 · 1 comment · Fixed by #293
Closed

Issues from #281 #285

BSd3v opened this issue Apr 22, 2024 · 1 comment · Fixed by #293

Comments

@BSd3v
Copy link
Collaborator

BSd3v commented Apr 22, 2024

@AnnMarieW
One more minor (and unrelated) item I found when I was updating the docs recently:

Console msg:

ag-grid-community.auto.esm.js:484 AG Grid: setDatasource is deprecated. Please use 'api.setGridOption('datasource', newValue)' or 'api.updateGridOptions({ datasource: newValue })' instead.

params.api.setDatasource(this.getDatasource());

Do you think you could include this small update in this PR?

@ndrezn
I am seeing:

tests/test_cell_data_type_override.py::test_cd001_cell_data_types_override FAILED                      [  5%]

E           selenium.common.exceptions.TimeoutException: Message: text -> 17/01/2024 not found within 10s, found: 04/02/11720

and:

tests/test_popupparent.py::test_pp001_popupParent FAILED                                               [ 60%]

E       selenium.common.exceptions.NoSuchElementException: Message: no such element: Unable to locate element: {"method":"css selector","selector":"body > .ag-popup .mantine-Select-input"}

failing locally but I believe this is unrelated to this PR.

@BSd3v BSd3v linked a pull request Apr 22, 2024 that will close this issue
@ndrezn
Copy link
Member

ndrezn commented Apr 23, 2024

Closing this because I think it was just a flakey local failure.

@ndrezn ndrezn closed this as completed Apr 23, 2024
@BSd3v BSd3v linked a pull request Apr 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants