Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to v31.1.0 #287

Closed
wants to merge 8 commits into from
Closed

bump to v31.1.0 #287

wants to merge 8 commits into from

Conversation

BSd3v
Copy link
Collaborator

@BSd3v BSd3v commented Apr 22, 2024

No description provided.

@BSd3v BSd3v linked an issue Apr 22, 2024 that may be closed by this pull request
@ndrezn ndrezn self-requested a review April 23, 2024 18:10
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@BSd3v
Copy link
Collaborator Author

BSd3v commented Apr 23, 2024

I'm working on something that I think will help with the flakey ness of the selectedRows tests

Copy link
Member

@ndrezn ndrezn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments to address, and then 💃

In the future I think we should make Ag Grid version bumps their own PR (this would also catch the test issue in that PR) but don't want to slow down progress for the sake of procedure 😛

@@ -8,13 +8,24 @@ Links "DE#nnn" prior to version 2.0 point to the Dash Enterprise closed-source D

### Changed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a new version number added rather than unreleased similar to others

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unreleased swaps to version number with the release of the new package, as we dont know what version these changes will be included in when adding. 😏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the release PR though?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you make the release in a separate PR. Along with npm updates.

"version": "31.0.1",
"version": "31.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted with @alexcjohnson -- I was wrong with the version bump; we follow the major version of Ag Grid only, so this would be a minor bump to 31.1.0. Sorry for the confusion here...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndrezn and @alexcjohnson

The main purpose of matching the the AG Grid versions is to give people an easy way to know the underlying AG Grid version. This makes it easier to know what version of their docs to use. This is important especially for Enterprise users because we have so few AG Grid Enterprise features documented.

Even in minor releases AG Grid adds a lot of features (especially Enterprise features) and deprecates props. I think it's helpful to match their release numbers as closely as possible. Given their rapid release schedule, I doubt we would ever need to release our own minor version before they would have another one out anyway.

Would you reconsider and make this release 31.2.0?

@ndrezn ndrezn changed the title bump to v31.2.1 bump to v31.1.0 Apr 24, 2024
@BSd3v BSd3v closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues from #281
3 participants