Column size updates #132
Merged
Column size updates #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o `columnSize` and `columnSizeOptions`
Closed
…ponsiveSizeToFit`
alexcjohnson
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
💃 Looks great - just a suggestion to make the prop type more precise, otherwise I think this is good to go. I still have some questions about how this will play with saving & restoring a grid, especially if the data may be different in the restored view. But I think in any event we'll be able to use this as a starting point and make non-breaking changes later if we find that something else is needed for that use case.
Co-authored-by: Alex Johnson <alex@plot.ly>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoSizeAllColumnscolumnSizeact upon updatecolumnSizeavailable,responsiveSizeToFitwhich will adjust column sizes based upon grid size and columns added or removedcolumnSizeOptionsto take an object that is compatible with AG Grid to perform sizing options as needed