Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floating-columnState #174

Merged
merged 13 commits into from
May 25, 2023
Merged

floating-columnState #174

merged 13 commits into from
May 25, 2023

Conversation

BSd3v
Copy link
Collaborator

@BSd3v BSd3v commented May 4, 2023

columnState floats during grid interaction and only gets pushed when sent in a callback
columnDefs trumps columnState if it is pushed in a callback without a columnState
Markdown renderer now will pass back '' instead of undefined if there isnt a value

@BSd3v BSd3v linked an issue May 4, 2023 that may be closed by this pull request
@BSd3v BSd3v linked an issue May 5, 2023 that may be closed by this pull request
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Alex Johnson <alex@plot.ly>
Comment on lines 236 to 240
(
ActionChains(dash_duo.driver)
.move_to_element(dash_duo.find_element('#load-column-defs'))
.click()
).perform()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some reason it doesn't work to just click the button? If it's scrolled off-screen maybe we can just put it on a new line or shorten the labels or something?

Suggested change
(
ActionChains(dash_duo.driver)
.move_to_element(dash_duo.find_element('#load-column-defs'))
.click()
).perform()
dash_duo.find_element('#load-column-defs').click()

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking it is too fast for some reason.

There has to be a slight pause between clicks or it doesn't work.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok - maybe just add a little time.sleep then, with a comment about why?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to avoid that. Haha.

But yes, a time.sleep works.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha yeah time.sleep is generally not great, but if there's a real reason we need a delay rather than waiting for a specific event, it's better to do that explicitly rather than something implicit like this.

Co-authored-by: Alex Johnson <alex@plot.ly>
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks great, just the last minor comment about time.sleep then we can merge. Very nice fixes and tests!

@BSd3v BSd3v merged commit a88af66 into plotly:dev May 25, 2023
@BSd3v BSd3v deleted the floating-columnState branch May 30, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants