-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
floating-columnState #174
floating-columnState #174
Conversation
…n sent in a callback
…pdate instead of querying from the grid each time
…iding the `columnState` when provided in a callback without `columnState`
Co-authored-by: Alex Johnson <alex@plot.ly>
tests/test_column_state.py
Outdated
( | ||
ActionChains(dash_duo.driver) | ||
.move_to_element(dash_duo.find_element('#load-column-defs')) | ||
.click() | ||
).perform() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some reason it doesn't work to just click the button? If it's scrolled off-screen maybe we can just put it on a new line or shorten the labels or something?
( | |
ActionChains(dash_duo.driver) | |
.move_to_element(dash_duo.find_element('#load-column-defs')) | |
.click() | |
).perform() | |
dash_duo.find_element('#load-column-defs').click() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clicking it is too fast for some reason.
There has to be a slight pause between clicks or it doesn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok - maybe just add a little time.sleep
then, with a comment about why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to avoid that. Haha.
But yes, a time.sleep works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha yeah time.sleep
is generally not great, but if there's a real reason we need a delay rather than waiting for a specific event, it's better to do that explicitly rather than something implicit like this.
Co-authored-by: Alex Johnson <alex@plot.ly>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Looks great, just the last minor comment about time.sleep
then we can merge. Very nice fixes and tests!
columnState
floats during grid interaction and only gets pushed when sent in a callbackcolumnDefs
trumpscolumnState
if it is pushed in a callback without acolumnState
Markdown
renderer now will pass back '' instead ofundefined
if there isnt a value