Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add n_clicks to cellClicked #19

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Conversation

AnnMarieW
Copy link
Collaborator

fixes #17

Added n_clicks data so setProps would update the data when the same cell is clicked on.

@BSd3v
Copy link
Collaborator

BSd3v commented Feb 2, 2023

@alexcjohnson, my thoughts are we should use a timestamp instead of n_clicks.

  • n_clicks is an extra state, though small, to keep track of
  • a timestamp may be useful as some point in time for gauging an user's level of interaction?

@alexcjohnson
Copy link
Collaborator

Ooh yeah I like the timestamp idea. As we go along we might end up adding other timestamps as well, and there may be use cases where you can see which is the latest timestamp across different classes of actions, which wouldn't be possible with n_clicks. Also n_clicks itself is ambiguous, does it mean number of clicks on this cell? on any cell? for this event (ie 2 would be a doubleclick)? We could document but if we use timestamp there's no need.

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Excellent!

@AnnMarieW AnnMarieW merged commit 2c4d13d into plotly:dev Feb 3, 2023
@AnnMarieW AnnMarieW deleted the fix-cellClicked branch February 3, 2023 20:23
BSd3v added a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AgGrid cellClicked not working twice in a row
3 participants