Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-filter-options #204

Merged
merged 5 commits into from
Jun 1, 2023
Merged

fix-filter-options #204

merged 5 commits into from
Jun 1, 2023

Conversation

BSd3v
Copy link
Collaborator

@BSd3v BSd3v commented May 30, 2023

fixing #203 by testing array for strings and only converting non-strings

@BSd3v BSd3v linked an issue May 30, 2023 that may be closed by this pull request
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 just one minor comment, looks great!

Co-authored-by: Alex Johnson <alex@plot.ly>
@alexcjohnson
Copy link
Collaborator

Oh and a changelog entry 😄

@BSd3v BSd3v merged commit cc45452 into plotly:dev Jun 1, 2023
@BSd3v BSd3v deleted the fixing-filter-options branch June 1, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filterOptions not working
2 participants