Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'domLayout': 'autoHeight' removes default 400px height #232

Merged
merged 7 commits into from
Oct 16, 2023

Conversation

aliwelchoo
Copy link
Contributor

No description provided.

@aliwelchoo
Copy link
Contributor Author

aliwelchoo commented Aug 3, 2023

To resolve issue #231

@BSd3v
Copy link
Collaborator

BSd3v commented Aug 4, 2023

You were closest on your first commit:

                height:
                        convertedProps.domLayout === 'autoHeight'
                            ? null
                            : '400px',

this will work in place of the height: "400px".

Thanks @alexcjohnson for the code.

@aliwelchoo, could you also please try to come up with a test for this use case?

BSd3v added 2 commits October 13, 2023 12:31
adjusting for the PR according to the recommendation
fixing for lint
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Thanks @aliwelchoo @BSd3v

@BSd3v BSd3v merged commit fff8ba1 into plotly:dev Oct 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'domLayout': 'autoHeight' goes below other components when grid height grows
3 participants