Use Github Actions rather than Circle for automated tests #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndrezn
commented
Apr 22, 2024
ndrezn
commented
Apr 22, 2024
| - name: Setup uv | ||
| run: | | ||
| curl -LsSf https://astral.sh/uv/install.sh | sh | ||
| uv venv |
There was a problem hiding this comment.
I'm using uv instead of pip for package installation to improve performance.
ndrezn
commented
Apr 22, 2024
.circleci/config.yml
Outdated
There was a problem hiding this comment.
We thank you for your service.
ndrezn
commented
Apr 22, 2024
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| react-version: ["18.2.0"] |
There was a problem hiding this comment.
@alexcjohnson , why was the previous test running a special check on 18.2.0?
There was a problem hiding this comment.
This was to test for forward compatibility for dash 2.17.
There was a problem hiding this comment.
Cool I suppose we can keep it till 2.17 rolls out
|
This is only failing due to circleci missing? |
|
Yeah I need to remove the circleCI config for this project. Then we should be good! |
|
I paused CircleCI builds on this project so this should pass without Circle on merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our other projects use GHA - let's switch this over too.