Automate generation of build files #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSd3v
reviewed
Apr 23, 2024
| node-version: "v18.16.0" | ||
| - uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: "3.10" |
There was a problem hiding this comment.
does this match the python-version in the AG Grid tests?
There was a problem hiding this comment.
The tests run on 3.8-3.12 inclusive: Because of this we expect a consistent build on any version and can increment this with some regular cadence.
|
@alexcjohnson if you're curious about implementation of the release process we chatted about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, when a new tag
v*is pushed, a draft release will be created with the build files automatically attached.Then, someone from the Plotly team should publish that draft release and upload the files to PyPI using Twine.