-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for JSON Parse error when using dash_ag_grid and dash pages #300
Conversation
@archmoj could you please have a look at this (or let us know that you don't feel you have enough context to review)? |
@BSd3v Thanks very much for the PR. It's looking good. @gvwilson I am not familiar with this repository. BTW. I was wondering perhaps this check could/should be moved to be inside |
Hello @archmoj,
|
Hello @gvwilson this issue can crop up at any point the grid is destroyed, this doesn't just apply to when using pages. Although it's a lot easier to test when using pages. 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
Looks good!
Fixes #299.