Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pivotComparator #325

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Fix pivotComparator #325

merged 4 commits into from
Sep 27, 2024

Conversation

AnnMarieW
Copy link
Collaborator

closes #324

@gvwilson gvwilson requested a review from BSd3v September 27, 2024 13:26
@gvwilson gvwilson added community community contribution fix fixes something broken P3 backlog labels Sep 27, 2024
BSd3v
BSd3v reviewed Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@BSd3v BSd3v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments. :)

CHANGELOG.md Outdated Show resolved Hide resolved
tests/assets/dashAgGridFunctions.js Outdated Show resolved Hide resolved
tests/test_pivot_column_order.py Outdated Show resolved Hide resolved
BSd3v
BSd3v approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@BSd3v BSd3v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to fix the failing test in another PR.

💃

@AnnMarieW AnnMarieW merged commit efaafdb into plotly:main Sep 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BSd3v BSd3v BSd3v approved these changes

Assignees

@AnnMarieW AnnMarieW

Labels
community community contribution fix fixes something broken P3 backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug-PivotComparator Sorting Issue in Ag-Grid Pivoted Table
3 participants
@AnnMarieW @BSd3v @gvwilson