Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Markdown replacing linkTarget in raw HTML: #45

Merged
merged 5 commits into from
Feb 22, 2023
Merged

Fixing Markdown replacing linkTarget in raw HTML: #45

merged 5 commits into from
Feb 22, 2023

Conversation

BSd3v
Copy link
Collaborator

@BSd3v BSd3v commented Feb 22, 2023 •
edited
Loading

@BSd3v
Fixing plotly#44:
360c9b7 
- added test to not replace `targetLink` if `dangerously_allow_code` is true
- added tests for markdown
@BSd3v BSd3v changed the title Fixing https://github.com/plotly/dash-ag-grid/issues/44: Fixing Markdown replacing linkTarget in raw HTML: Feb 22, 2023
@BSd3v BSd3v linked an issue Feb 22, 2023 that may be closed by this pull request
Markdown html links with target="_blank not opening in new tab #44
Closed
@BSd3v BSd3v requested a review from alexcjohnson February 22, 2023 20:08
@BSd3v @alexcjohnson
Update src/lib/renderers/markdownRenderer.js
bb80893 
Co-authored-by: Alex Johnson <alex@plot.ly>
alexcjohnson
alexcjohnson approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Beautiful 😎

@BSd3v BSd3v merged commit e3c6158 into plotly:dev Feb 22, 2023
alexcjohnson added a commit that referenced this pull request Feb 23, 2023
@alexcjohnson
changelog for PRs #45 and #47
c45b54a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markdown html links with target="_blank not opening in new tab
2 participants
@BSd3v @alexcjohnson