Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prop cleanup #81

Merged
merged 18 commits into from
Mar 15, 2023
Merged

Prop cleanup #81

merged 18 commits into from
Mar 15, 2023

Conversation

BSd3v
Copy link
Collaborator

@BSd3v BSd3v commented Mar 10, 2023 •
edited
Loading

  • prop clean-up overhaul
  • updating testing that broke due to props no longer being on the grid, but in dashGridOptions
  • added testing for selection and sizing buttons
  • removed cellStyle from the grid level, allowing more flexibility in customization, and alignment with AG grid
  • allowed for functions, styleConditions and regular dictionaries to be passed to the cellStyle on all levels
  • added rowId to cellClicked data
  • added tests for cellClicked data

BSd3v and others added 8 commits March 6, 2023 15:17
@BSd3v
beginning progress on prop cleanup
389b087
@BSd3v
Merge branch 'plotly:dev' into prop-cleanup
f9b4d26
@BSd3v
Merge branch 'plotly:dev' into prop-cleanup
9554183
@BSd3v
- prop clean-up overhaul
646e3f6 
- updating testing that broke due to props no longer being on the grid, but in `dashGridOptions`
- added testing for selection and sizing buttons
@BSd3v
updating changelog
e3fd987
@BSd3v
- adding the tests previously mentioned
1db8c05
@BSd3v
- defining props where available
ddba553 
- fixed error when in not in client-side rowmodel to try to set filter and sort mode
@BSd3v
- fixing missing rowModelType declare
a4ab7c5
@BSd3v BSd3v linked an issue Mar 10, 2023 that may be closed by this pull request
Clearing rows of a grid with infinite row model #59
Closed
@AnnMarieW
Copy link
Collaborator

This looks good!

Can we add add row ID to `cellClicked'?
https://github.com/plotly/dash-ag-grid/blob/dev/src/lib/fragments/AgGrid.react.js#L466

@BSd3v
Copy link
Collaborator Author

BSd3v commented Mar 13, 2023

I am going to change nodeId to rowId as well for cellValueChanged, that way it lines up.

@AnnMarieW, @alexcjohnson

BSd3v and others added 5 commits March 13, 2023 16:10
@BSd3v
- changed nodeId -> rowId to line up with other areas in `cellVal…
8838a59 
…ueChanged`

- added `rowId` to `cellClicked` data
- added tests for `cellClicked` data
@BSd3v
updating changelog
9d29ce9
@BSd3v
Merge branch 'plotly:dev' into prop-cleanup
51bf5ad
@BSd3v
- fixed issue where rowData and virtualRowData were out of sync w…
bb9d1ec 
…ith what the grid was showing

- added tests for `rowData` and `virtualRowData` syncing
@BSd3v
updating changelog
24a9980
BSd3v and others added 4 commits March 14, 2023 19:32
@BSd3v @alexcjohnson
Update src/lib/components/AgGrid.react.js
3472c81 
Co-authored-by: Alex Johnson <alex@plot.ly>
@BSd3v @alexcjohnson
Update src/lib/components/AgGrid.react.js
c87dc8b 
Co-authored-by: Alex Johnson <alex@plot.ly>
@BSd3v @alexcjohnson
Update src/lib/components/AgGrid.react.js
7088d68 
Co-authored-by: Alex Johnson <alex@plot.ly>
@BSd3v @alexcjohnson
Update src/lib/components/AgGrid.react.js
859a514 
Co-authored-by: Alex Johnson <alex@plot.ly>
@BSd3v @alexcjohnson
Update src/lib/components/AgGrid.react.js
c3093bb 
Co-authored-by: Alex Johnson <alex@plot.ly>
alexcjohnson
alexcjohnson approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, much cleaner! 💃

@BSd3v BSd3v merged commit 36d1886 into plotly:dev Mar 15, 2023
@BSd3v BSd3v deleted the prop-cleanup branch March 15, 2023 13:37
@BSd3v BSd3v mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clearing rows of a grid with infinite row model
3 participants
@BSd3v @AnnMarieW @alexcjohnson