Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing defaultStyle in the cellStyle prop when only listed #92

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Fixing defaultStyle in the cellStyle prop when only listed #92

merged 2 commits into from
Mar 16, 2023

Conversation

BSd3v
Copy link
Collaborator

@BSd3v BSd3v commented Mar 16, 2023 •
edited
Loading

  • added test for defaultStyle in the cellStyle when styleConditions is not also provided
  • added tests for defaultStyle

alexcjohnson
alexcjohnson approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@alexcjohnson alexcjohnson merged commit f14d5b5 into plotly:dev Mar 16, 2023
@BSd3v BSd3v deleted the fixing-default-styles branch March 16, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BSd3v @alexcjohnson