This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Fix dash-core-compoents Slider and RangeSlider tooltip #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AboorvaDevarajan
requested review from
alexcjohnson,
byronz and
Marc-Andre-Rivet
as code owners
|
Thanks @AboorvaDevarajan -but I think the problem is much simpler: we just need to reverse the order of arguments to |
skip adding visible attribute to the tooltip object to avoid invalid attribute error.
AboorvaDevarajan
force-pushed
the
fix_tooltip
branch
from
5b28941
to
6216fda
Compare
|
@alexcjohnson Yes, that should be simpler. I have updated the PR. |
|
With reference to #648 I will close this. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced the same issue as #640, with this patch I was able to get it working, and it could be a potential fix.