Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Issue 652 - Fix ramda usage #653

Merged
merged 3 commits into from
Sep 18, 2019
Merged

Issue 652 - Fix ramda usage #653

merged 3 commits into from
Sep 18, 2019

Conversation

Marc-Andre-Rivet
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet commented Sep 18, 2019

Fixes #652

@alexcjohnson
Copy link
Collaborator

ugh, sorry about that. I forgot about that change, is this more mis-caching?
I know table uses this pattern, but the rest of this package uses import {stuff} from 'ramda'; though, would you mind keeping to that pattern?

@Marc-Andre-Rivet
Copy link
Contributor Author

@alexcjohnson Sure. I can update usage in dcc to use import { stuff }

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 💃

@Marc-Andre-Rivet Marc-Andre-Rivet marked this pull request as ready for review September 18, 2019 19:41
@Marc-Andre-Rivet Marc-Andre-Rivet merged commit d387c73 into dev Sep 18, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the 652-ramda branch September 18, 2019 19:41
@byronz
Copy link
Contributor

byronz commented Sep 18, 2019

ugh, sorry about that. I forgot about that change, is this more mis-caching?

verified with the build, not a caching issue in this case

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] DatePickerSingle broken in Dash 1.3.0
3 participants