Update Plotly.js to 1.52.1 #732
Conversation
| @@ -230,6 +230,7 @@ def check_graph_config_shape(dash_dcc): | |||
| 'showSources', | |||
| 'logging', | |||
| 'globalTransforms', | |||
| 'notifyOnLogging', | |||
There was a problem hiding this comment.
@alexcjohnson We already ignore logging, seems like we probably want to ignore another logging themed prop, but need to be certain.
There was a problem hiding this comment.
Yes, for now we can ignore this one. In fact notifyOnLogging would be useful to dash - and alongside it logging becomes useful - because this repeats console log messages into the UI as notification boxes. Unfortunately right now this can only be used globally (Plotly.setPlotConfig), not per-plot in the config prop. In fact the better solution for dash will be when we have logging events plotly/plotly.js#4462, and we can hopefully pass these along to the main dash devtools.
| @@ -28,7 +27,7 @@ | |||
| "prebuild:js": "cp node_modules/plotly.js/dist/plotly.min.js dash_core_components_base/plotly.min.js", | |||
| "build:js": "webpack --mode production", | |||
| "build:py_and_r": "dash-generate-components ./src/components dash_core_components -p package-info.json && cp dash_core_components_base/** dash_core_components/ && dash-generate-components ./src/components dash_core_components -p package-info.json --r-prefix 'dcc'", | |||
| "build": "run-s build:js generator build:py_and_r", | |||
There was a problem hiding this comment.
Some extra clean up / simplification, this is no longer necessary b/c of the prebuild command.
| - Upgraded plotly.js to [1.52.1](https://github.com/plotly/plotly.js/releases/tag/v1.52.1) | ||
| - [Feature release 1.52.0](https://github.com/plotly/plotly.js/releases/tag/v1.52.0) which contains: | ||
| - Enable loading locale bundles before plotly.js bundles [#4453](https://github.com/plotly/plotly.js/pull/4453) | ||
| - `ko` localization [#4315](https://github.com/plotly/plotly.js/pull/4315) |
There was a problem hiding this comment.
@alexcjohnson Added these based on previous entries (ko) and because of its significance for async/Dash. Feel free to add other items that are relevant.
There was a problem hiding this comment.
That's fine, good call pointing out the ordering fix. Aside from that, there are no new trace types in 1.52, that's the most important thing to include.
From Dash, for cross-testing
https://percy.io/plotly/dash/builds/3749412
https://circleci.com/gh/plotly/dash/tree/plotlyjs-1.52.1