This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
fixes tooltips on RangeSlider #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnMarieW
requested review from
alexcjohnson,
Marc-Andre-Rivet and
rpkyle
as code owners
alexcjohnson
approved these changes
May 13, 2021
There was a problem hiding this comment.
Thanks @AnnMarieW - this looks great! 💃
Let's see if the tests pass with the merge of the latest dev, ie was CircleCI just having a bad day or is there really something wrong.
| dash_dcc.start_server(app) | ||
| dash_dcc.wait_for_element("#test-slider") | ||
| dash_dcc.percy_snapshot( | ||
| "slider-make sure tooltips are only visible if parent slider is visible" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #885
Closes #919
Closes #763
This applies the fix from #878 to the RangeSlider. It not only fixes the bug where the tooltips were visible when slider was not, but it also reduces the lag in the tooltips when the slider handles are moved.