-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade versions #202
Upgrade versions #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working for me! 💃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on my machine with npm install
-> npm run build:all
followed by trying out several demos in the browser, including usage_cy_leaflet_aio.py
. All working for me!
I'll defer to @alexcjohnson for the specifics of the CICD and Javascript conventions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Fantastic! Just two small comments then we're ready to merge 🎉
About
General update of versions.
Description of changes
requirements.txt
andtests/requirements.txt
as the minimum python version is now 3.8.dash-leaflet
totests/requirements.txt
Pre-Merge checklist
npm run build:all
.