Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade versions #202

Merged
merged 20 commits into from
Jan 25, 2024
Merged

Upgrade versions #202

merged 20 commits into from
Jan 25, 2024

Conversation

Farkites
Copy link
Contributor

@Farkites Farkites commented Jan 23, 2024

About

General update of versions.

Description of changes

  • Upgraded minimum python version of 3.8
    • Removed conditional versions in requirements.txt and tests/requirements.txt as the minimum python version is now 3.8.
    • Upgraded python version for CICD to 3.8.18
  • Updated all JS dependencies.
  • Fixed lint errors introduced in Add CyLeaflet AIO component #200
  • Added dash-leaflet to tests/requirements.txt

Pre-Merge checklist

  • The project was correctly built with npm run build:all.
  • If there was any conflict, it was solved correctly.
  • All changes were documented in CHANGELOG.md.
  • All tests on CircleCI have passed.
  • All Percy visual changes have been approved.
  • Two people have 💃'd the pull request. You can be one of these people if you are a Dash Cytoscape core contributor.

@Farkites Farkites requested review from emilykl and cleaaum January 23, 2024 11:49
Copy link
Contributor

@cleaaum cleaaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me! 💃

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my machine with npm install -> npm run build:all followed by trying out several demos in the browser, including usage_cy_leaflet_aio.py. All working for me!

I'll defer to @alexcjohnson for the specifics of the CICD and Javascript conventions.

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Fantastic! Just two small comments then we're ready to merge 🎉

@Farkites Farkites merged commit 43433b0 into master Jan 25, 2024
2 checks passed
@alexcjohnson alexcjohnson deleted the upgrade-python-version branch January 25, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants