-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/update maxzoom cyleaflet #216
Conversation
@Farkites I've noticed something that looks like a bug -- when the Screen.Recording.2024-05-13.at.6.07.25.PM.movI know Leaflet is finicky and maybe there's no easy fix, but IMO the ideal would be that the map automatically zooms out to match the new max zoom. |
I found a way to fix this. On the event I haven't found a way to do this from the clientside callbacks since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @Farkites , thanks for chasing down these loose ends. 🔥
Look into my comments before merging but I don't want to block you any further so I'll approve -- on the whole this looks great.
One more thing to check before merging -- can you confirm that the scenario described in #205 works properly now? I.e., switching out the leaflet children
for a tile layer with a different maxZoom
updates the behavior of the CyLeaflet as expected?
🦾 Thx!
Yes, it works as expected! |
About
This PR adds two bug fixes for the issues #208, #207, and #205 regarding the CyLeaflet AIO component.
Description of changes
#205:
dcc.Store
has been added to the AIO component containing the data of the last leafletextent
state so that when the leaflet tiles contain a newmaxZoom
theextent
isn't lost.updateLeafBounds
callback.usage_cy_leaflet_aio.py
has been updated to include a leaflet maxZoom input.#208:
TransformElements
allows duplicate outputs for the cytoscape elements.dcc.Store
elements
whenever cytoscape elements change has been added.usage_cy_leaflet_aio.py
has been updated to include a number of elements for cytoscape input.#207:
elements
dcc.Store
.Pre-Merge checklist
npm run build:all
.Reference Issues
Closes #208
Closes #205
Closes #207