Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React 16.12 #81

Closed
wants to merge 1 commit into from
Closed

React 16.12 #81

wants to merge 1 commit into from

Conversation

Marc-Andre-Rivet
Copy link
Contributor

Companion to plotly/dash#1145

@xhluca xhluca marked this pull request as ready for review May 19, 2020 22:08
@xhluca xhluca self-requested a review May 20, 2020 18:31
xhluca
xhluca reviewed May 20, 2020
View reviewed changes
Copy link

@xhluca xhluca left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks like a very straightforward PR. I would be happy to directly merge it, but with more reflection, I was wondering: would there be breaking changes after this PR? For example,

  • Currently, Dash Cytoscape v0.1.1 can be used with Dash 0.39, and seems to also be compatible with Dash 1.x
  • After this PR, will Dash Cytoscape (master version) be compatible with Dash 0.39?

If there are such breaking changes, it would be a good idea to publish this in Dash-cytoscape v1.x (to match Dash version) or v0.2/0.3 (which would technically be against semver but accepted by many open-source projects).

@alexcjohnson
Copy link
Collaborator

Semver normally allows breaking changes within the 0.x series, it's not until 1.0 that a breaking change requires a major bump. And you already have enough unreleased changes to justify 0.2. So I'd make sure @Marc-Andre-Rivet is happy with it and tests are passing, then merge away 🎉

@xhluca
Copy link

xhluca commented May 20, 2020

Didn't know that about semver; thanks!

@AnnMarieW AnnMarieW mentioned this pull request Jan 18, 2021
Merged
@xhluca
Copy link

xhluca commented Feb 12, 2021

Done in #117 and #123

@xhluca xhluca closed this Feb 12, 2021
@xhluca xhluca deleted the exp-react-16.12 branch May 25, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhluca xhluca xhluca left review comments

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson alexcjohnson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Marc-Andre-Rivet @alexcjohnson @xhluca