Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Commit

Permalink
Merge pull request #108 from plotly/remove-authentication
Browse files Browse the repository at this point in the history
Remove `Authentication` component.
  • Loading branch information
T4rk1n authored Dec 18, 2018
2 parents f45d2c9 + 2071021 commit 7812cba
Show file tree
Hide file tree
Showing 11 changed files with 3,430 additions and 4,343 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [UNRELEASED] - 2018-12-17
### Removed
- Unused login api and Authentication component [#108](https://github.com/plotly/dash-renderer/pull/108)

## [0.16.1] - 2018-12-14
### Fixed
- Added `key` to rendered components, fixing [#379](https://github.com/plotly/dash-core-components/issues/379)
Expand Down
7,461 changes: 3,402 additions & 4,059 deletions dash_renderer/dash_renderer.dev.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dash_renderer/dash_renderer.dev.js.map

Large diffs are not rendered by default.

19 changes: 4 additions & 15 deletions dash_renderer/dash_renderer.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dash_renderer/dash_renderer.min.js.map

Large diffs are not rendered by default.

23 changes: 17 additions & 6 deletions src/AppContainer.react.js
Original file line number Diff line number Diff line change
@@ -1,26 +1,37 @@
import {connect} from 'react-redux';
import React from 'react';
import Authentication from './Authentication.react';
import PropTypes from 'prop-types';
import APIController from './APIController.react';
import DocumentTitle from './components/core/DocumentTitle.react';
import Loading from './components/core/Loading.react';
import Toolbar from './components/core/Toolbar.react';
import Reloader from './components/core/Reloader.react';
import {readConfig} from './actions';

function UnconnectedAppContainer() {
return (
<Authentication>
class UnconnectedAppContainer extends React.Component {

componentWillMount() {
const {dispatch} = this.props;
dispatch(readConfig())
}

render() {
return (
<div>
<Toolbar />
<APIController />
<DocumentTitle />
<Loading />
<Reloader />
</div>
</Authentication>
);
);
}
}

UnconnectedAppContainer.propTypes = {
dispatch: PropTypes.func,
};

const AppContainer = connect(
state => ({
history: state.history,
Expand Down
253 changes: 0 additions & 253 deletions src/Authentication.react.js

This file was deleted.

6 changes: 0 additions & 6 deletions src/actions/api.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,6 @@ export function getDependencies() {
return apiThunk('_dash-dependencies', 'GET', 'dependenciesRequest');
}

export function login(oauth_token) {
return apiThunk('_dash-login', 'POST', 'loginRequest', '', '', {
Authorization: `Bearer ${oauth_token}`,
});
}

export function getReloadHash() {
return apiThunk('_reload-hash', 'GET', 'reloadRequest');
}
1 change: 1 addition & 0 deletions src/components/core/Reloader.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ class Reloader extends React.Component {
) {
// Look if it was a css file.
let was_css = false;
// eslint-disable-next-line prefer-const
for (let a of reloadRequest.content.files) {
if (a.is_css) {
was_css = true;
Expand Down
1 change: 0 additions & 1 deletion src/reducers/api.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,4 @@ function createApiReducer(store) {

export const dependenciesRequest = createApiReducer('dependenciesRequest');
export const layoutRequest = createApiReducer('layoutRequest');
export const loginRequest = createApiReducer('loginRequest');
export const reloadRequest = createApiReducer('reloadRequest');
1 change: 0 additions & 1 deletion src/reducers/reducer.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const reducer = combineReducers({
config,
dependenciesRequest: API.dependenciesRequest,
layoutRequest: API.layoutRequest,
loginRequest: API.loginRequest,
reloadRequest: API.reloadRequest,
history,
});
Expand Down

0 comments on commit 7812cba

Please sign in to comment.