Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Bug editing column names while columns are hidden #576

Closed
alexcjohnson opened this issue Sep 6, 2019 · 2 comments · Fixed by #578
Closed

Bug editing column names while columns are hidden #576

alexcjohnson opened this issue Sep 6, 2019 · 2 comments · Fixed by #578
Assignees
@alexcjohnson
Labels
dash-type-bug Something isn't working as intended size: 0.2
Milestone
Dash v1.3.0

Comments

@alexcjohnson
Copy link
Collaborator

Causes hidden columns to be dropped entirely
@alexcjohnson alexcjohnson added the dash-type-bug Something isn't working as intended label Sep 6, 2019
@alexcjohnson alexcjohnson added this to the Dash v1.3.0 milestone Sep 6, 2019
@alexcjohnson alexcjohnson self-assigned this Sep 6, 2019
@alexcjohnson
Copy link
Collaborator Author

also applies to deleting columns while some are hidden - but clearing seems OK. Might be some "interesting" edge cases though when merged columns are partially hidden...

@Marc-Andre-Rivet
Copy link
Contributor

This is the only instance in which visibleColumns is used instead of columns for an operation on the columns.

https://github.com/plotly/dash-table/blob/master/src/dash-table/derived/header/content.tsx#L275
https://github.com/plotly/dash-table/blob/master/src/dash-table/utils/actions.js#L59

Causes invalid updates to columns and data fields.

alexcjohnson added a commit that referenced this issue Sep 8, 2019
@alexcjohnson
fix #576 - edits while some columns are hidden preserve hidden columns
755e247
alexcjohnson added a commit that referenced this issue Sep 8, 2019
@alexcjohnson
fix #576 - edits while some columns are hidden preserve hidden columns
2d30db0
@alexcjohnson alexcjohnson mentioned this issue Sep 8, 2019
Merged
@alexcjohnson alexcjohnson mentioned this issue Oct 2, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexcjohnson alexcjohnson

Labels
dash-type-bug Something isn't working as intended size: 0.2
Projects
None yet
Milestone
Dash v1.3.0
Development

Successfully merging a pull request may close this issue.

576 - column edits with hidden columns plotly/dash-table
2 participants
@alexcjohnson @Marc-Andre-Rivet