This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Fix short Firefox cell height for dropdown cells #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbrgss
requested review from
alexcjohnson and
Marc-Andre-Rivet
as code owners
|
Before After |
wbrgss
changed the title
|
Looking at Percy, this seems to fix what I wanted on Firefox (and there are 11 more Firefox changes in the diff), but it also seems to shorten rows without dropdowns (?), including in Chrome. |
|
OK, I changed the style rules and got it down to 11 Firefox diffs and 0 Chrome diffs, which is what I want. Please review when you have a chance @Marc-Andre-Rivet |
|
@wbrgss Updated the branch and added a changelog file |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #663 (issue described in detail there; TLDR Firefox table cell height is off)
Solution from https://stackoverflow.com/questions/3215553/make-a-div-fill-an-entire-table-cell#comment40719119_7600749I don't think this has any side effects with Chrome; i.e. it only helps parity between Chrome and FF rendering.