Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Issue 807 - Customizable Markdown options #808

Merged
merged 5 commits into from
Jul 22, 2020
Merged

Conversation

Marc-Andre-Rivet
Copy link
Contributor

Fixes #807

Allows configuring markdown options at the table-level and will be compatible with future extensions if/when markdown support is increased.

Use the following value to open links in the current tab and get the behaviour as before #787

markdown_options={"linkTarget": "_self"}

@Marc-Andre-Rivet Marc-Andre-Rivet marked this pull request as ready for review July 22, 2020 16:41
- support free form string for linkTarget
@chriddyp
Copy link
Member

maybe link_target to keep our property naming consistent?

@Marc-Andre-Rivet
Copy link
Contributor Author

@chriddyp Will do. Requires mapping the API props to internal props for the Markdown library but no problem otherwise.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💃

Co-authored-by: alexcjohnson <johnson.alex.c@gmail.com>
@Marc-Andre-Rivet Marc-Andre-Rivet merged commit ee4a469 into dev Jul 22, 2020
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the 807-markdown-link branch July 22, 2020 20:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table markdown link opening new tab is problematic for certain workflows
3 participants