fix prod build

plotly · May 7, 2021 · 20b67ab · 20b67ab
1 parent 95821cd
commit 20b67ab
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/dash-renderer/package.json b/dash-renderer/package.json
@@ -9,8 +9,8 @@
     "private::format.prettier": "prettier --write \"{src,tests}/**/*.{js,jsx,ts,tsx}\"",
     "private::lint.eslint": "eslint src tests",
     "private::lint.prettier": "prettier \"{src,tests}/**/*.{js,jsx,ts,tsx}\" --list-different",
-    "build:js": "webpack --mode production",
-    "build:dev": "webpack --mode development",
+    "build:js": "webpack",
+    "build:dev": "webpack",
     "build:local": "renderer build local",
     "build": "renderer build && npm run prepublishOnly",
     "postbuild": "es-check es5 dash_renderer/*.js",

diff --git a/dash-renderer/webpack.base.config.js b/dash-renderer/webpack.base.config.js
@@ -59,10 +59,15 @@ module.exports = options => [
         rendererOptions
     ]),
     R.mergeAll([
+        options,
+        rendererOptions,
         {
             mode: 'production',
             output: {
+                path: path.resolve(__dirname, dashLibraryName),
                 filename: `${dashLibraryName}.min.js`,
+                library: dashLibraryName,
+                libraryTarget: 'window',
             },
             plugins: R.concat(
                 options.plugins || [],
@@ -78,8 +83,6 @@ module.exports = options => [
                     ),
                 ]
             ),
-        },
-        options,
-        rendererOptions
+        }
     ])
 ];