Skip to content

Commit

Permalink
Merge pull request #1894 from plotly/random-id-errors
Browse files Browse the repository at this point in the history
error when autogenerated IDs are used with persistence or snapshots
  • Loading branch information
alexcjohnson authored Jan 27, 2022
2 parents 0f1b299 + 75e938e commit 3334c07
Show file tree
Hide file tree
Showing 29 changed files with 276 additions and 770 deletions.
327 changes: 139 additions & 188 deletions .circleci/config.yml

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# These owners will be the default owners for everything in
# the repo. Unless a later match takes precedence
* @alexcjohnson @Marc-Andre-Rivet @rpkyle
* @alexcjohnson
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ This project adheres to [Semantic Versioning](https://semver.org/).
return f'You have entered {value}'
```

[#1894](https://github.com/plotly/dash/pull/1894) restricted this feature so auto-generated IDs are not allowed if the app uses `dash_snapshots` (a Dash Enterprise package) or if the component uses `persistence`, as this can create confusing errors. Callback definitions can still reference components in these cases, but those components must have explicit IDs.

## Dash Core Components

### Rearranged Keyword Arguments & Flexible Types
Expand Down
188 changes: 0 additions & 188 deletions components/dash-core-components/.circleci/config.yml

This file was deleted.

3 changes: 0 additions & 3 deletions components/dash-core-components/.github/CODEOWNERS

This file was deleted.

1 change: 0 additions & 1 deletion components/dash-core-components/.github/FUNDING.yml

This file was deleted.

8 changes: 0 additions & 8 deletions components/dash-core-components/dev-requirements.txt

This file was deleted.

2 changes: 1 addition & 1 deletion components/dash-core-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"private::format.black": "black dash_core_components_base/ tests/ setup.py",
"private::format.eslint": "eslint src --fix",
"private::format.prettier": "prettier --config .prettierrc --write src/**/*.js",
"private::lint.black": "if [ \"$PYTHON_VERSION\" != \"py27\" ]; then black --check dash_core_components_base/ tests/ setup.py; fi",
"private::lint.black": "black --check dash_core_components_base/ tests/ setup.py",
"private::lint.eslint": "eslint src",
"private::lint.flake8": "flake8 --exclude=dash_core_components,node_modules,venv",
"private::lint.prettier": "prettier --config .prettierrc src/**/*.js --list-different",
Expand Down
94 changes: 0 additions & 94 deletions components/dash-html-components/.circleci/config.yml

This file was deleted.

3 changes: 0 additions & 3 deletions components/dash-html-components/.github/CODEOWNERS

This file was deleted.

1 change: 0 additions & 1 deletion components/dash-html-components/.github/FUNDING.yml

This file was deleted.

3 changes: 0 additions & 3 deletions components/dash-html-components/dev-requirements.txt

This file was deleted.

Loading

0 comments on commit 3334c07

Please sign in to comment.