Merge pull request #2892 from aGitForEveryone/dropdown-menu-max-heigh…

…t-fix Dropdown menu max height fix
plotly · Jun 21, 2024 · b13d9b8 · b13d9b8
2 parents 3203b0f + 3f446f4
commit b13d9b8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
 
 ## Fixed
 
+- [#2892](https://github.com/plotly/dash/pull/2860) Fix ensures dcc.Dropdown menu maxHeight option works with Datatable. Fixes [#2529](https://github.com/plotly/dash/issues/2529) [#2225](https://github.com/plotly/dash/issues/2225)
 - [#2896](https://github.com/plotly/dash/pull/2896) The tabIndex parameter of Div can accept number or string type. Fixes [#2891](https://github.com/plotly/dash/issues/2891)
 
 ## [2.17.1] - 2024-06-12

diff --git a/components/dash-core-components/src/components/css/Dropdown.css b/components/dash-core-components/src/components/css/Dropdown.css
@@ -1,7 +1,8 @@
 .dash-dropdown .Select-menu-outer {
     z-index: 1000;
+    max-height: none;
 }
 
-.dash-dropdown .Select-menu, .Select-menu-outer {
+.dash-dropdown .Select-menu {
     max-height: none;
 }
diff --git a/components/dash-core-components/tests/integration/dropdown/test_visibility.py b/components/dash-core-components/tests/integration/dropdown/test_visibility.py
@@ -50,7 +50,10 @@ def test_ddvi001_fixed_table(dash_duo):
 def test_ddvi002_maxHeight(dash_duo):
     app = Dash(__name__)
     app.layout = Div(
-        [Dropdown([str(i) for i in range(100)], "1", id="dropdown", maxHeight=800)]
+        [
+            DataTable(),  # ensure datatable css does not override maxHeight #2529
+            Dropdown([str(i) for i in range(100)], "1", id="dropdown", maxHeight=800),
+        ]
     )
 
     dash_duo.start_server(app)